update referenced file name due to change with serverless offline upgrade #2
Conversation
index.js
Outdated
| // TODO: send PR to serverless-offline to export this | ||
| const functionHelper = require('serverless-offline/src/functionHelper') | ||
| const createLambdaContext = require('serverless-offline/src/createLambdaContext') | ||
| const createLambdaContext = require('serverless-offline/src/LambdaContext') |
There was a problem hiding this comment.
How about something like-
let createLambdaContext = null;
try {
// Support serverless-offline prior to version x.y.z.
createLambdaContext = require('serverless-offline/src/createLambdaContext')
} catch(e) {
try {
// Support serverless-offline after version x.y.z.
createLambdaContext = require('serverless-offline/src/LambdaContext')
} catch(e) {
// burgers and fries
}
}
There was a problem hiding this comment.
We discussed exactly that. Long story, long.. Houston doesn't need ssl for serverless iot local anymore so we may not need the fork of serverless-iot-local which then means we can send this fix to tradle as a PR instead of maintaining the fork.. and no, he didn't fix it yet either. Another ticket for another time. We'll defer the upgrade of serverless-offline.
There was a problem hiding this comment.
We still use iot for local serverless-offline testing. We likely still need this plugin.
There was a problem hiding this comment.
Is there something in the fork that we need for off-line testing?
There was a problem hiding this comment.
Yes, we need the plugin for testing.
There was a problem hiding this comment.
Why would we fork anything? Keep this plugin. Problem solved.
There was a problem hiding this comment.
You're going to need to explain better than word circling (or squaring).
There was a problem hiding this comment.
Going with the answer you gave me yesterday.
3 participants
No description provided.